coydog/zmap-freebsd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up snprintf and buffer size (less sloppy).

Browse Source
This commit is contained in:
HD Moore 2013-08-17 15:16:35 -05:00
parent 60011ca520
commit c455d99298
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/output_modules/module_json.c
View File

@ -143,7 +143,7 @@ int json_output_file_ip(ipaddr_n_t saddr, ipaddr_n_t daddr,
struct iphdr *ip_hdr = (struct iphdr *)&packet[sizeof(struct ethhdr)]; struct iphdr *ip_hdr = (struct iphdr *)&packet[sizeof(struct ethhdr)];
int data_offset = 0; int data_offset = 0;
struct timeval t; struct timeval t;
char tbuff[16]; char tbuff[10];
struct tcphdr *tcp; struct tcphdr *tcp;
struct udphdr *udp; struct udphdr *udp;
struct icmphdr *icmp; struct icmphdr *icmp;
@ -208,8 +208,7 @@ int json_output_file_ip(ipaddr_n_t saddr, ipaddr_n_t daddr,
break; break;
default: default:
memset(tbuff, 0, sizeof(tbuff)); snprintf(tbuff, sizeof(tbuff), "proto-%d", ip_hdr->protocol);
snprintf(tbuff, sizeof(tbuff)-1, "proto-%d", ip_hdr->protocol);
json_object_object_add(obj, "proto", json_object_new_string(tbuff)); json_object_object_add(obj, "proto", json_object_new_string(tbuff));
} }